Add button check to validateUILayout #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification, the broker can only specify a button for the layout if wait == true, otherwise the layout is invalid and an error should be returned.
Now that wait == true is required in order to also use a button, the layout should specify it.
denisonbarbosa
force-pushed
the
form-button-validation
branch
from
ece966f
to
d19597d
Compare
GabrielNagy
reviewed
Aug 8, 2023
| @@ -190,6 +190,9 @@ func validateUILayout(layout map[string]string) (r map[string]string, err error) | |||
| if !slices.Contains([]string{"true", "false", ""}, wait) { | |||
| return nil, fmt.Errorf("'wait' does not match allowed values for this type: %v", wait) | |||
| } | |||
| if button != "" && wait != "true" { | |||
| return nil, errors.New("button is not allowed if wait is not true") | |||
There was a problem hiding this comment.
Just a nit, do you mind aligning to fmt.Errorf since it's used throughout the function? Or changing the other calls with no interpolations to use errors.New as well (in a separate commit obviously).
We were using fmt.Errorf() to create errors without any formatting, so it's better to switch to errors.New().
GabrielNagy
approved these changes
Aug 8, 2023
|
As said during the meeting, the spec is now amended, and this button will do another select check. This is then not useful anymore and we should not call IsAuthorized to signal sms changes, but rather when we enter the selection mode. Discaring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, the broker can only specify a button for the layout if wait == true, otherwise the layout is invalid and an error should be returned.